Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make media-pickers expanded attr a prop #4986

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Make media-pickers expanded attr a prop #4986

merged 1 commit into from
Jul 2, 2020

Conversation

emptynick
Copy link
Collaborator

This makes the media-pickers expanded attribute a prop so it functions as described in the docs.

Fixes #4984

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #4986 into 1.4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                1.4    #4986   +/-   ##
=========================================
  Coverage     62.96%   62.96%           
  Complexity     1372     1372           
=========================================
  Files           194      194           
  Lines          4007     4007           
=========================================
  Hits           2523     2523           
  Misses         1484     1484           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b099792...0f8f967. Read the comment docs.

@emptynick emptynick merged commit 413ad90 into 1.4 Jul 2, 2020
@emptynick emptynick deleted the mp-expanded branch July 2, 2020 12:56
rozaverta added a commit to rozaverta/voyager that referenced this pull request Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media Picker is always expanded even when setting "expanded":false
1 participant