Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setSettingsAttribute for null values #4981

Merged
merged 3 commits into from
Jul 6, 2020
Merged

Conversation

magarrent
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #4981 into 1.4 will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                1.4    #4981   +/-   ##
=========================================
  Coverage     62.96%   62.96%           
- Complexity     1372     1373    +1     
=========================================
  Files           194      194           
  Lines          4007     4007           
=========================================
  Hits           2523     2523           
  Misses         1484     1484           
Impacted Files Coverage Δ Complexity Δ
src/Models/User.php 100.00% <100.00%> (ø) 7.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56bef5c...86d4b8d. Read the comment docs.

@emptynick emptynick merged commit 865209f into thedevdojo:1.4 Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants