Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix picking media not updating thumbnails #4970

Merged
merged 2 commits into from
Jul 6, 2020
Merged

Fix picking media not updating thumbnails #4970

merged 2 commits into from
Jul 6, 2020

Conversation

emptynick
Copy link
Collaborator

When a file was double-click to pick it, the UI didn't refresh.
This fixes it.
Also fixed a problem where images weren't displayed when the extension was uppercase (ex. myfile.JPG)

Fixes #4969

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #4970 into 1.4 will not change coverage.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                1.4    #4970   +/-   ##
=========================================
  Coverage     62.96%   62.96%           
  Complexity     1372     1372           
=========================================
  Files           194      194           
  Lines          4007     4007           
=========================================
  Hits           2523     2523           
  Misses         1484     1484           
Impacted Files Coverage Δ Complexity Δ
src/Traits/Translatable.php 37.65% <75.00%> (ø) 61.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865209f...a198eee. Read the comment docs.

Copy link
Collaborator

@MrCrayon MrCrayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👍
This is the reason I thought it was buggy but I never looked into it properly.

@emptynick emptynick merged commit ec68bb5 into 1.4 Jul 6, 2020
@emptynick emptynick deleted the fix-picking-media branch July 6, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selecting Image using Image Picker does not update thumbnail until clicking another image
2 participants