Fix translations loaded when not needed #4955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR only moves translations loading after check `$default == $locale` that has a return and does not need translations to be loaded. This because when current locale is the default one we don't to load translations when getTranslateAttribute is called.
Codecov Report
@@ Coverage Diff @@
## 1.4 #4955 +/- ##
=========================================
Coverage 62.96% 62.96%
Complexity 1372 1372
=========================================
Files 194 194
Lines 4007 4007
=========================================
Hits 2523 2523
Misses 1484 1484
Continue to review full report at Codecov.
|
emptynick
approved these changes
May 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only moves translations loading after check
$default == $localethat has a return and does not need translations to be loaded.This because when current locale is the default one we don't need to load translations when getTranslateAttribute is called.