Fix filter null values when array does not start with 0 #4937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```php
[
120 => ["order" => 1].
240 => ["order" => 2],
]
```
That kind of data caused:
```
ErrorException
Undefined offset: 0
```
To be honest I cannot replicate at all the problem that thedevdojo#3350 PR was solving even totally removing the code, but I only changed it because it might happen in some occasion that I'm unable to reproduce.
MrCrayon
force-pushed
the
fix-filter-null-values-in-contenttype-relationship
branch
from
23b5a59
to
ef1d13b
Compare
Codecov Report
@@ Coverage Diff @@
## 1.4 #4937 +/- ##
============================================
+ Coverage 62.94% 62.96% +0.01%
+ Complexity 1374 1372 -2
============================================
Files 194 194
Lines 4008 4007 -1
============================================
Hits 2523 2523
+ Misses 1485 1484 -1
Continue to review full report at Codecov.
|
emptynick
approved these changes
May 17, 2020
rozaverta
added a commit
to rozaverta/voyager
that referenced
this pull request
Jul 7, 2020
MrCrayon
deleted the
fix-filter-null-values-in-contenttype-relationship
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3350 assumes arrays always starts with 0 and are ordered but this is not true for custom selects that might pass additional data for pivot tables like this:
[ 120 => ["order" => 1]. 240 => ["order" => 2], ]That kind of data caused:
To be honest I cannot replicate at all the problem that #3350 PR was solving even totally removing the code, but I only changed it because it might happen in some occasion that I'm unable to reproduce.