Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation for array elements #4922

Conversation

MrCrayon
Copy link
Collaborator

@MrCrayon MrCrayon commented May 6, 2020

Fixes validation when array does not contain files, ex. belongsToMany relationship.

Symfony\Component\Debug\Exception\FatalThrowableError
Call to a member function getClientOriginalName() on string

Fixes validation when array does not contain files, ex. belongsToMany relationship.
@MrCrayon MrCrayon added the bugfix label May 6, 2020
@MrCrayon MrCrayon requested a review from emptynick May 6, 2020 04:03
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #4922 into 1.4 will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.4    #4922      +/-   ##
============================================
- Coverage     62.97%   62.96%   -0.01%     
- Complexity     1373     1374       +1     
============================================
  Files           194      194              
  Lines          4005     4007       +2     
============================================
+ Hits           2522     2523       +1     
- Misses         1483     1484       +1     
Impacted Files Coverage Δ Complexity Δ
src/Http/Controllers/Controller.php 80.85% <66.66%> (-0.45%) 77.00 <0.00> (+1.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c113a4...53ed5cb. Read the comment docs.

@EduCavalheiro
Copy link

Tested, it works well.

@emptynick emptynick merged commit f44d661 into thedevdojo:1.4 May 8, 2020
@MrCrayon MrCrayon deleted the fix-array-elements-validation-for-non-files branch May 12, 2020 04:11
rozaverta added a commit to rozaverta/voyager that referenced this pull request Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants