Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix additional attribute not listed #4884

Merged

Conversation

MrCrayon
Copy link
Collaborator

Additional attribute is not an object like other table columns.

Schermata da 2020-04-13 12-36-37

Fixes #4882

Co-Authored-By: tjebe tjebe@users.noreply.github.com

Additional attribute is not an object like other table columns.

Fixes thedevdojo#4882

Co-Authored-By: tjebe <tjebe@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #4884 into 1.4 will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                1.4    #4884   +/-   ##
=========================================
  Coverage     62.93%   62.93%           
  Complexity     1373     1373           
=========================================
  Files           194      194           
  Lines          3996     3996           
=========================================
  Hits           2515     2515           
  Misses         1481     1481           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55d6d04...075e9ad. Read the comment docs.

Copy link
Collaborator

@emptynick emptynick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@emptynick emptynick merged commit ce12c09 into thedevdojo:1.4 Apr 14, 2020
@MrCrayon MrCrayon deleted the fix-additional-attribute-not-listed branch May 12, 2020 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model's additional attributes no longer show up in a relationship's display select list
2 participants