Fix voyager models not returning save result #4881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Result is needed while checking on restore, it's also how parent method is defined. https://github.com/laravel/framework/blob/55070d4e57abd710783d29329d6f6846b570f452/src/Illuminate/Database/Eloquent/Model.php#L666 Fixes thedevdojo#4880
Codecov Report
@@ Coverage Diff @@
## 1.4 #4881 +/- ##
=========================================
Coverage 62.93% 62.93%
Complexity 1373 1373
=========================================
Files 194 194
Lines 3996 3996
=========================================
Hits 2515 2515
Misses 1481 1481
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result is needed while checking on restore, it's also how parent method is defined.
https://github.com/laravel/framework/blob/55070d4e57abd710783d29329d6f6846b570f452/src/Illuminate/Database/Eloquent/Model.php#L666
Fixes #4880