Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix additional attributes when using local scope #4875

Merged
merged 3 commits into from
May 8, 2020
Merged

Fix additional attributes when using local scope #4875

merged 3 commits into from
May 8, 2020

Conversation

arxeiss
Copy link
Contributor

@arxeiss arxeiss commented Apr 6, 2020

Fix error: Property [additional_attributes] does not exist on the Eloquent builder instance.

This happens, when a local scope is used. Then $model does not contain Model but Builder.

@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #4875 into 1.4 will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.4    #4875      +/-   ##
============================================
- Coverage     62.96%   62.94%   -0.02%     
  Complexity     1374     1374              
============================================
  Files           194      194              
  Lines          4007     4008       +1     
============================================
  Hits           2523     2523              
- Misses         1484     1485       +1     
Impacted Files Coverage Δ Complexity Δ
src/Http/Controllers/VoyagerBaseController.php 57.07% <0.00%> (-0.15%) 143.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e40b11...3b351ad. Read the comment docs.

Copy link
Collaborator

@MrCrayon MrCrayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see thanks

@emptynick
Copy link
Collaborator

I'm more curious if the accessor is available on a Builder instance then?

@moisesh18
Copy link

This worked for me. Why it is not in merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants