-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable customization of TinyMCE init options #4727
Enable customization of TinyMCE init options #4727
Conversation
Works well thanks - needed to re-compile via npm due to error: I tested by importing extra tinymce plugin into my use of the voyager additional_js importing the extra tinymce plugin there which works well with your changes. It would be great if tinymce/ace editors were not so tightly coupled into the main voyager app.js file and loaded separately when needed. |
Codecov Report
@@ Coverage Diff @@
## 1.4 #4727 +/- ##
======================================
Coverage ? 60.34%
Complexity ? 1373
======================================
Files ? 194
Lines ? 3992
Branches ? 0
======================================
Hits ? 2409
Misses ? 1583
Partials ? 0 Continue to review full report at Codecov.
|
670b126
to
ad2448c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple things:
Lets move the documentation from customization/tinymce.md
and merge them together with what you created.
You also need to add a link in summary.md
to your new file.
Also it is not very clear to me where I have to put the tinymceOptions
.
tinymceOptions go in BREAD details, I should add that. |
tinymce_init_callback and tinymce_setup_callback can only be used effectively to set events or do something after tinyMCE has been initialized, to change init options tinymce currently needs to be initialized, destroyed and reinitialized with new settings. This PR: Exports default settings options Moves initialization to rich_text_box.blade file Checks if custom options are set in BREAD details to merge Enables different settings for each textarea Closes thedevdojo#4551
Added not in upgrade guide Added link in summary Clarified where to set tinymceOptions
4439495
to
e088513
Compare
@emptynick I added a note to upgrade documentation, let me know if that's clear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's better
tinymce_init_callback
andtinymce_setup_callback
can only be used effectively to set events or do something after tinyMCE has been initialized, to change init options tinymce currently needs to be initialized, destroyed and reinitialized with new settings.This PR:
rich_text_box
blade fileWarning
If tinyMCE was used without calling
rich_text_box
partial it will need to be initialized:Closes #4551