Remove Route in InstallCommand #4692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Routes needed to be defined on install for old Voyager versions because MenuItemsTableSeeder used to seed the full url into database. That's not the case anymore so this can be removed. This part of code was also causing routes on tests to be defined in a different order than normal use because on install Route was called before seeding DataTypes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Routes needed to be defined on install for old Voyager versions because MenuItemsTableSeeder used to seed the full url into database.
That's not the case anymore so this can be removed.
This part of code was also causing routes on tests to be defined in a different order than normal use because on install Route was called before seeding DataTypes.