Fix display name for new BREAD field #4666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case $dataRow didn't exists a string was passed to _field_trans instead of a json array. Just the default language is enough in json array.
Codecov Report
@@ Coverage Diff @@
## 1.3 #4666 +/- ##
=======================================
Coverage 59.9% 59.9%
Complexity 1366 1366
=======================================
Files 194 194
Lines 3963 3963
=======================================
Hits 2374 2374
Misses 1589 1589Continue to review full report at Codecov.
|
fletch3555
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case
$dataRowdidn't exists a string was passed to_field_transinstead of a json array.Just the default language is enough in json array.
Fixes #4665