Fix validation for arrays #4648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fletch3555
previously approved these changes
Dec 20, 2019
change fieldName after we use the original value
MrCrayon
force-pushed
the
fix-validation-for-arrays
branch
from
c99b326
to
63e2ce2
Compare
Codecov Report
@@ Coverage Diff @@
## 1.3 #4648 +/- ##
===========================================
+ Coverage 59.82% 59.9% +0.07%
Complexity 1366 1366
===========================================
Files 194 194
Lines 3963 3963
===========================================
+ Hits 2371 2374 +3
+ Misses 1592 1589 -3
Continue to review full report at Codecov.
|
fletch3555
approved these changes
Dec 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #4624 I realized file I commited was not up to date.
I would also like to add tests later today.Tests added
Closes #1501