Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Cloud Storage #4565

Merged
merged 18 commits into from
Apr 5, 2020
Merged

Support for Cloud Storage #4565

merged 18 commits into from
Apr 5, 2020

Conversation

faizananwerali
Copy link
Contributor

@faizananwerali faizananwerali commented Nov 15, 2019 •
edited by emptynick

Support for Cloud Storage (Google Bucket/Amazon S3) without breaking local and public storage

Fixes #4477

@faizananwerali faizananwerali mentioned this pull request Nov 15, 2019
Closed
fletch3555
fletch3555 previously requested changes Nov 15, 2019
View reviewed changes
src/Http/Controllers/VoyagerMediaController.php Outdated Show resolved Hide resolved
src/Http/Controllers/VoyagerMediaController.php Outdated Show resolved Hide resolved
src/Http/Controllers/VoyagerMediaController.php Outdated Show resolved Hide resolved
src/Http/Controllers/VoyagerMediaController.php Outdated Show resolved Hide resolved
@MrCrayon
Copy link
Collaborator

Honestly I think this is the wrong approach, upload works so we know we can get the right path that works in all storages without all trial and error
What I would like to see is full path for what works:

  • upload
  • delete?
  • move?
  • rename?

And full path for what doesn't work, then we can spot the difference and fix it.

@faizananwerali
Copy link
Contributor Author

faizananwerali commented Nov 16, 2019 via email •
edited

@MrCrayon
Copy link
Collaborator

@faizananwerali you can contact me in Voyager Slack Channel

@faizananwerali
Fix Media Manager for Cloud storage
a4e1e91 
Fixed by MrCrayon. thedevdojo/voyager@1.3...MrCrayon:03f2af479612e20718cacfcf4c5240b2e982049b
Image can't read from cloud so we need to get open the image with Storage and pass the content to Image, inverted process for saving.
Storage should be used without $realPath.
$image->encode()->encoded returns the image as string.
@faizananwerali
Fix Media Manager for Cloud storage
eb07898 
Fixed by MrCrayon. the-control-group/voyager@1.3...MrCrayon:03f2af479612e20718cacfcf4c5240b2e982049b
Image can't read from cloud so we need to get open the image with Storage and pass the content to Image, inverted process for saving.
Storage should be used without $realPath.
$image->encode()->encoded returns the image as string.
@faizananwerali
Fix Media Manager for Cloud storage
0001e11 
Fixed by MrCrayon. the-control-group/voyager@1.3...MrCrayon:03f2af479612e20718cacfcf4c5240b2e982049b
Image can't read from cloud so we need to get open the image with Storage and pass the content to Image, inverted process for saving.
Storage should be used without $realPath.
$image->encode()->encoded returns the image as string.
@faizananwerali
Support for Cloud Storage
182dbbb 
Fixed by MrCrayon. the-control-group/voyager@1.3...MrCrayon:03f2af479612e20718cacfcf4c5240b2e982049b
Image can't read from cloud so we need to get open the image with Storage and pass the content to Image, inverted process for saving.
Storage should be used without $realPath.
$image->encode()->encoded returns the image as string.
@faizananwerali
Fix Media Manager for Cloud storage by MrCrayon
e401ee4 
Fixed by MrCrayon. the-control-group/voyager@1.3...MrCrayon:03f2af479612e20718cacfcf4c5240b2e982049b
Image can't read from cloud so we need to get open the image with Storage and pass the content to Image, inverted process for saving.
Storage should be used without $realPath.
$image->encode()->encoded returns the image as string.
@faizananwerali
Copy link
Contributor Author

faizananwerali commented Nov 20, 2019 •
edited

Fixed by MrCrayon. MrCrayon@03f2af4
Image can't read from cloud so we need to get open the image with Storage and pass the content to Image, inverted process for saving.
Storage should be used without $realPath.
$image->encode()->encoded returns the image as string.

MrCrayon
MrCrayon requested changes Dec 20, 2019
View reviewed changes
Copy link
Collaborator

@MrCrayon MrCrayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the empty lines for clarity.

src/Http/Controllers/VoyagerMediaController.php Show resolved Hide resolved
src/Http/Controllers/VoyagerMediaController.php Show resolved Hide resolved
src/Http/Controllers/VoyagerMediaController.php Show resolved Hide resolved
MrCrayon
MrCrayon previously approved these changes Dec 23, 2019
View reviewed changes
Copy link
Collaborator

@MrCrayon MrCrayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@codecov
Copy link

codecov bot commented Dec 30, 2019 •
edited

Codecov Report

Merging #4565 into 1.4 will decrease coverage by 0.04%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.4    #4565      +/-   ##
============================================
- Coverage     63.04%   63.00%   -0.05%     
  Complexity     1369     1369              
============================================
  Files           194      194              
  Lines          3986     3992       +6     
============================================
+ Hits           2513     2515       +2     
- Misses         1473     1477       +4
Impacted Files Coverage Δ Complexity Δ
src/Http/Controllers/VoyagerMediaController.php 14.95% <33.33%> (+0.53%) 59.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd9385b...0a4e879. Read the comment docs.

@MrCrayon MrCrayon mentioned this pull request Jan 12, 2020
Closed
@faizananwerali
Copy link
Contributor Author

I don't understand the holdup for merging. Can you please merge it master branch so I don't have to override class

@faizananwerali
Copy link
Contributor Author

what the heck do I have to do to get this pull request approved? I mean I don't understand what do you want more.

@emptynick emptynick dismissed MrCrayon’s stale review April 5, 2020 14:00

The base branch was changed.

@emptynick emptynick changed the base branch from 1.3 to 1.4 April 5, 2020 14:00
@emptynick
Copy link
Collaborator

Thanks. But please, watch your tone.
We are all volunteers and have jobs.
It sometimes just takes some time.

@emptynick emptynick removed the request for review from fletch3555 April 5, 2020 14:05
@emptynick emptynick merged commit e70cd09 into thedevdojo:1.4 Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emptynick emptynick emptynick approved these changes

@fletch3555 fletch3555 fletch3555 left review comments

@MrCrayon MrCrayon MrCrayon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Heroku Amazon s3 “Image source not readable” on upload error
4 participants
@faizananwerali @MrCrayon @emptynick @fletch3555