-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Cloud Storage #4565
Conversation
Support for Cloud Storage (Google Bucket/Amazon S3) without breaking local and public storage
Support for Cloud Storage
Honestly I think this is the wrong approach, upload works so we know we can get the right path that works in all storages without all trial and error
And full path for what doesn't work, then we can spot the difference and fix it. |
Can I give you amazon s3 and Google Bucket Iamuser credentials? Because I
literally don't have anytime this month to debug and both on local and live
server
|
@faizananwerali you can contact me in Voyager Slack Channel |
Fixed by MrCrayon. thedevdojo/voyager@1.3...MrCrayon:03f2af479612e20718cacfcf4c5240b2e982049b Image can't read from cloud so we need to get open the image with Storage and pass the content to Image, inverted process for saving. Storage should be used without $realPath. $image->encode()->encoded returns the image as string.
Fixed by MrCrayon. the-control-group/voyager@1.3...MrCrayon:03f2af479612e20718cacfcf4c5240b2e982049b Image can't read from cloud so we need to get open the image with Storage and pass the content to Image, inverted process for saving. Storage should be used without $realPath. $image->encode()->encoded returns the image as string.
Fixed by MrCrayon. the-control-group/voyager@1.3...MrCrayon:03f2af479612e20718cacfcf4c5240b2e982049b Image can't read from cloud so we need to get open the image with Storage and pass the content to Image, inverted process for saving. Storage should be used without $realPath. $image->encode()->encoded returns the image as string.
Fixed by MrCrayon. the-control-group/voyager@1.3...MrCrayon:03f2af479612e20718cacfcf4c5240b2e982049b Image can't read from cloud so we need to get open the image with Storage and pass the content to Image, inverted process for saving. Storage should be used without $realPath. $image->encode()->encoded returns the image as string.
Fixed by MrCrayon. the-control-group/voyager@1.3...MrCrayon:03f2af479612e20718cacfcf4c5240b2e982049b Image can't read from cloud so we need to get open the image with Storage and pass the content to Image, inverted process for saving. Storage should be used without $realPath. $image->encode()->encoded returns the image as string.
Fixed by MrCrayon. MrCrayon@03f2af4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the empty lines for clarity.
Restored extra lines as request thedevdojo#4565 (review)
Restored extra lines as requested by MrCrayon thedevdojo#4565 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
Codecov Report
@@ Coverage Diff @@
## 1.4 #4565 +/- ##
============================================
- Coverage 63.04% 63.00% -0.05%
Complexity 1369 1369
============================================
Files 194 194
Lines 3986 3992 +6
============================================
+ Hits 2513 2515 +2
- Misses 1473 1477 +4
Continue to review full report at Codecov.
|
I don't understand the holdup for merging. Can you please merge it master branch so I don't have to override class |
what the heck do I have to do to get this pull request approved? I mean I don't understand what do you want more. |
Thanks. But please, watch your tone. |
Support for Cloud Storage (Google Bucket/Amazon S3) without breaking local and public storage
Fixes #4477