Enhance Widget Layout #4559
Merged
Enhance Widget Layout #4559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts on dashboard page. dimmers.blade.php now runs through an array filled with widgetGroups Voyager.php's 'dimmers()' function now returns an array filled wih WidgetGroups
Removing old, commented code that is not needed anymore.
Updating test and test documentation to fit with the current Dimmer paradigm Adding in a new test to go over a new constraint through this update. That a dimmer group can only have a max three dimmers.
Spraynard
changed the title
MrCrayon
requested changes
Nov 20, 2019
MrCrayon
requested changes
Nov 21, 2019
| @@ -64,5 +83,7 @@ public function testEachDimmerGroupHasAMaxAmountOfThreeDimmers() | |||
| $dimmers = Voyager::dimmers(); | |||
|
|
|||
| $this->assertEquals(2, count($dimmers)); | |||
| $this->assertEquals(3, $dimmers[0]->count()); | |||
There was a problem hiding this comment.
This assertion proves what you were trying to prove in the previous test, so I think the other one can be removed.
MrCrayon
requested changes
Nov 21, 2019
Removing unnecessary test
MrCrayon
approved these changes
Nov 21, 2019
|
Thank you very much for the help as well. It's much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update contains two changes to two different files.
I had an issue similar to Issue #3185 and was able to implement a solution that works along with the current voyager configuration but allow for more than three widgets to be on the dashboard window.
This is what the dashboard window looks like with 1 - 3 Widgets
This is what the dashboard window looks like with 5 widgets
Please let me know if there is any more information needed