Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu JSON object #3571

Merged
merged 4 commits into from
Oct 16, 2018
Merged

Menu JSON object #3571

merged 4 commits into from
Oct 16, 2018

Conversation

Labelsuisse
Copy link
Contributor

@Labelsuisse Labelsuisse commented Sep 21, 2018 •
edited
Loading

Returns a menu in JSON format by setting a type to _json.

@tnylea
Copy link
Collaborator

tnylea commented Sep 26, 2018

@Labelsuisse Rad!

Just tested it out. Works like a charm ;)

@fletch3555 This one should be good to go whenever you're ready.

tnylea
tnylea approved these changes Oct 1, 2018
View reviewed changes
Copy link
Collaborator

@tnylea tnylea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go. I've downloaded this version and checked it out. Works amazing 👍

@fletch3555
Copy link
Collaborator

@Labelsuisse, where does $type == '_json' come from? I think we need some documentation added for this.

@emptynick emptynick mentioned this pull request Oct 4, 2018
Closed
@fletch3555 fletch3555 merged commit f410318 into thedevdojo:1.1 Oct 16, 2018
@emptynick emptynick mentioned this pull request Dec 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnylea tnylea tnylea approved these changes

@fletch3555 fletch3555 fletch3555 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Labelsuisse @tnylea @fletch3555