Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added preserveFileUploadName also for FILE #3164

Merged
merged 3 commits into from
Aug 7, 2018

Conversation

reficul
Copy link

@reficul reficul commented May 10, 2018

This PR continue to use random as default but I think that is better for 1.1 to set original filenames as default and random as option. There is the whole question of “SEO” and the possibility for users to have more recognizable files that I think should lead to reverse things.

Gabriele Venturini added 2 commits May 10, 2018 14:19
This PR continue to use random as default but I think that is better for 1.1 to set original filenames as default and random as option. There is the whole question of “SEO” and the possibility for users to have more recognizable files that I think should lead to reverse things.
Copy link
Author

@reficul reficul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TravisFix

@fletch3555 fletch3555 merged commit 8105516 into thedevdojo:1.1 Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants