Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Expo): bump Expo Adapters version from 13.0 to 13.4 #482

Closed
wants to merge 1 commit into from

Conversation

mihailapuste
Copy link

Bumped iOS deployment target to 13.4 to support expo sdk 50

@mihailapuste mihailapuste changed the title expo 50 support Bumped iOS deployment target to 13.4 to support expo sdk 50 Jan 3, 2024
@mihailapuste mihailapuste changed the title Bumped iOS deployment target to 13.4 to support expo sdk 50 feat(Expo): bump Expo Adapters version from 13.0 to 13.4 Jan 3, 2024
@mikehardy
Copy link
Collaborator

I am unsure why supporting a new version of Expo requires a breaking change in the expo adapters for all expo users? 🤔

@mikehardy mikehardy added question Further information is requested needs more info waiting on original poster to provide details labels Feb 1, 2024
@mihailapuste
Copy link
Author

mihailapuste commented Feb 2, 2024

@mikehardy Sorry for the late reply!
That absolutely makes sense, no reason to merge with breaking changes for now. I've personally forked for my own needs.
However I thought of perhaps leaving his here, perhaps it will be needed, and if not, please feel free to close.

Expo 50 now has a minimum deployment target of 13.4

Notable breaking changes
iOS minimum deployment target bumped to 13.4.

I will also look into a potential solution to support both if I can find one, open to any suggestions or ideas in the time being.

Thank you !

@mikehardy
Copy link
Collaborator

mikehardy commented Feb 2, 2024

There are easier ways I think? I do something like this to line up my targets, in my Podfile

min_ios_version_supported = '13.4'


post_install do |installer|

  # ...lots of stuff

  installer.pods_project.targets.each do |target|

    target.build_configurations.each do |config|

      # Quiets all the noise about misaligned deployment targets
      config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = min_ios_version_supported
    end
  end

  # ...anything else you might need

end

@mihailapuste
Copy link
Author

There are easier ways I think? I do something like this to line up my targets, in my Podfile

min_ios_version_supported = '13.4'


post_install do |installer|

  # ...lots of stuff

  installer.pods_project.targets.each do |target|

    target.build_configurations.each do |config|

      # Quiets all the noise about misaligned deployment targets
      config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = min_ios_version_supported
    end
  end

  # ...anything else you might need

end

This seems to have done the trick. Thank you for your help 🚀 @mikehardy

Copy link

stale bot commented Mar 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 4, 2024
@stale stale bot closed this Mar 12, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs more info waiting on original poster to provide details question Further information is requested wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants