fix: correct button management for disabled state

theKashey · Feb 14, 2022 · 463682e · 463682e
1 parent 36f4540
commit 463682e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.size.json b/.size.json
@@ -2,6 +2,6 @@
   {
     "name": "dist/es2015/index.js",
     "passed": true,
-    "size": 2536
+    "size": 2558
   }
 ]
diff --git a/src/utils/is.ts b/src/utils/is.ts
@@ -53,11 +53,14 @@ export const getDataset = (node: Element): HTMLElement['dataset'] | undefined =>
 
 export const isHTMLButtonElement = (node: Element): node is HTMLInputElement => node.tagName === 'BUTTON';
 export const isHTMLInputElement = (node: Element): node is HTMLInputElement => node.tagName === 'INPUT';
+
 export const isRadioElement = (node: Element): node is HTMLInputElement =>
   isHTMLInputElement(node) && node.type === 'radio';
 
 export const notHiddenInput = (node: Element): boolean =>
-  !((isHTMLInputElement(node) || isHTMLInputElement(node)) && (node.type === 'hidden' || node.disabled));
+  !((isHTMLInputElement(node) || isHTMLButtonElement(node)) && (node.type === 'hidden' || node.disabled)) &&
+  // @ts-ignore
+  !node.ariaDisabled;
 export const isGuard = (node: Element | undefined): boolean => Boolean(node && getDataset(node)?.focusGuard);
 export const isNotAGuard = (node: Element | undefined): boolean => !isGuard(node);
 

diff --git a/src/utils/tabbables.ts b/src/utils/tabbables.ts
@@ -6,6 +6,8 @@ export const tabbables = [
   'select:enabled',
   'textarea:enabled',
   'input:enabled',
+  // elements with explicit roles will also use explicit tabindex
+  // '[role="button"]',
 
   'a[href]',
   'area[href]',