Fix query: different results for rate function when not dedup or using implicit step interval #7341 #7498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tizki
force-pushed
the
fix-7341-different-results-for-rate-function
branch
from
14f825c
to
02d70dc
Compare
Signed-off-by: Tidhar Klein Orbach <tidhar.o@taboola.com>
Signed-off-by: Tidhar Klein Orbach <tidhar.o@taboola.com>
Signed-off-by: Tidhar Klein Orbach <tidhar.o@taboola.com>
Signed-off-by: Tidhar Klein Orbach <tidhar.o@taboola.com>
Signed-off-by: Tidhar Klein Orbach <tidhar.o@taboola.com>
Allow suppressing environment variables expansion errors when unset, and thus keep the reloader from crashing. Instead leave them as is. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com> Signed-off-by: Tidhar Klein Orbach <tidhar.o@taboola.com>
* Update adopters.yml Signed-off-by: Rishabh Soni <risrock02@gmail.com> * Add files via upload Signed-off-by: Rishabh Soni <risrock02@gmail.com> --------- Signed-off-by: Rishabh Soni <risrock02@gmail.com> Signed-off-by: Tidhar Klein Orbach <tidhar.o@taboola.com>
Endpoints are currently closed as soon as we receive a SIGTERM or SIGINT. This causes in-flight queries to get cancelled since outgoing connections get closed instantly. This commit moves the endpoints.Close call after the grpc server shutdown to make sure connections are available as long as the server is running. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Signed-off-by: Tidhar Klein Orbach <tidhar.o@taboola.com>
Signed-off-by: Tidhar Klein Orbach <tidhar.o@taboola.com>
tizki
force-pushed
the
fix-7341-different-results-for-rate-function
branch
from
4513404
to
d68d260
Compare
| mutex sync.Mutex | ||
| ) | ||
|
|
||
| func InitialPenalty(value int64) { |
There was a problem hiding this comment.
Can we inject the penalty into the dedup iterator instead of setting the global variable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I added query.dedup-penalty to allow passing a different initial value for the default penalty of the deduplication algorithm.
see issue #7341
Verification
added a unit test case for the usage of the new setting.