Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s3: change AWS S3 authentication sequence #732

Merged
merged 2 commits into from
Jan 14, 2019
Merged

s3: change AWS S3 authentication sequence #732

merged 2 commits into from
Jan 14, 2019

Conversation

arnitolog
Copy link
Contributor

Changes

authentication sequence changed to the following:

  1. config file
  2. Environment variables
  3. ~/.aws/credentials
  4. IAM instance profile

Verification

built it locally and used env vars for thanos store and thanos compactor. both were able to access S3 without any errors.

bwplotka
bwplotka approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks a lot!

@bwplotka bwplotka merged commit 4e20faf into thanos-io:master Jan 14, 2019
@bwplotka bwplotka mentioned this pull request Jan 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnitolog @bwplotka