Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable scalar for vertical sharding #6212

Merged

Conversation

justinjung04
Copy link
Contributor

@justinjung04 justinjung04 commented Mar 14, 2023

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes #6209

Verification

Added a test case for scalar function to not expect sharding

@justinjung04 justinjung04 force-pushed the disable-scalar-vertical-sharding branch 2 times, most recently from 5274b4a to 711ffef Compare March 14, 2023 05:13
Signed-off-by: Justin Jung <jungjust@amazon.com>
@justinjung04 justinjung04 force-pushed the disable-scalar-vertical-sharding branch from 711ffef to ead360e Compare March 14, 2023 05:40
@justinjung04 justinjung04 marked this pull request as ready for review March 14, 2023 06:06
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LTGM

Copy link
Contributor

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@yeya24 yeya24 merged commit 06d9da4 into thanos-io:main Mar 14, 2023
Kartik-Garg pushed a commit to infracloudio/thanos that referenced this pull request Mar 14, 2023
Signed-off-by: Justin Jung <jungjust@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable vertical sharding when scalar function is present
3 participants