Remove tenant shipper after prunning #6207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We noticed another edge case with tenant prunning where the shipper would keep syncing blocks even after the tenant TSDB was removed. The reason for this is because the shipper runs in parallel in a different goroutine and is not stopped when the TSDB is gone. This leads to empty shipper files being created on disk once a tenant is pruned, and the orphaned TSDBs alert from the mixing starts to fire. This commit modifies the pruning logic to remove all components from a tenant once eviction conditions have been met. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
fpetkovski
commented
Mar 10, 2023
| @@ -425,7 +425,7 @@ func TestMultiTSDBPrune(t *testing.T) { | |||
| name: "prune tsdbs with object storage", | |||
| bucket: objstore.NewInMemBucket(), | |||
| expectedTenants: 2, | |||
| expectedUploads: 1, | |||
| expectedUploads: 2, | |||
There was a problem hiding this comment.
This is now 2 because background syncs are constantly running, so the compacted tenant gets uploaded.
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed another edge case with tenant prunning where the shipper would keep syncing blocks even after the tenant TSDB was removed. The reason for this is because the shipper runs in parallel in a different goroutine and is not stopped when the TSDB is gone.
This leads to empty shipper files being created on disk once a tenant is pruned, and the orphaned TSDBs alert from the mixing starts to fire.
This commit modifies the pruning logic to remove all components from a tenant once eviction conditions have been met.
Changes
Verification