Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to go1.11.1 and move to modules #602

Closed
wants to merge 12 commits into from
Closed

Update to go1.11.1 and move to modules #602

wants to merge 12 commits into from

Conversation

domgreen
Copy link
Contributor

Changes

Updating to go1.11.1 and modules ... experimental change. Locally works well but want to test CI.

  • also had to update the recent azure and ignoring an error check ... may fail the build

Verification

Currently able to run make all locally

@domgreen domgreen self-assigned this Oct 30, 2018
@domgreen
Copy link
Contributor Author

Currently blocked on our usage of errcheck as it currently does not support go mod ... issue has been filed kisielk/errcheck#155

@sylr
Copy link
Contributor

sylr commented Feb 18, 2019

Hey @domgreen, could we move forward with this ?

@domgreen
Copy link
Contributor Author

@sylr feel free to pick this up, the errcheck issue seems to be fixed now 👍

@domgreen
Copy link
Contributor Author

Should also look at bumping to go1.11.5

@sylr
Copy link
Contributor

sylr commented Feb 18, 2019

All right I'll see what I can do tomorrow 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants