cacheutil: add support for Redis Sentinel #5990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
force-pushed
the
add_support_for_master_redis
branch
2 times, most recently
from
e64a749
to
0ade90a
Compare
GiedriusS
changed the title
GiedriusS
force-pushed
the
add_support_for_master_redis
branch
from
0ade90a
to
33a3003
Compare
|
Need another fix for the conflict :) |
|
Maybe worth adding a mention in the that docs that Redis Sentinel is now supported? |
Add a new option `master_name` that if not empty chooses the appropriate master. Reusing terminology used by Cortex and official Redis documentation (https://redis.io/docs/management/sentinel/). Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
force-pushed
the
add_support_for_master_redis
branch
from
33a3003
to
01a91f9
Compare
|
Updated PR. There's an item in the changelog for Redis Sentinel 😄 |
|
Thanks a lot, @GiedriusS 🙇 |
yeya24
approved these changes
Jan 2, 2023
Kartik-Garg
pushed a commit
to infracloudio/thanos
that referenced
this pull request
Jan 16, 2023
Add a new option `master_name` that if not empty chooses the appropriate master. Reusing terminology used by Cortex and official Redis documentation (https://redis.io/docs/management/sentinel/). Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Signed-off-by: Kartik-Garg <kartik.garg@infracloud.io>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
Add a new option `master_name` that if not empty chooses the appropriate master. Reusing terminology used by Cortex and official Redis documentation (https://redis.io/docs/management/sentinel/). Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
Add a new option `master_name` that if not empty chooses the appropriate master. Reusing terminology used by Cortex and official Redis documentation (https://redis.io/docs/management/sentinel/). Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Dogface18
approved these changes
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new option
master_namethat if not empty chooses the appropriate master. Reusing terminology used by Cortex and official Redis documentation (https://redis.io/docs/management/sentinel/).Signed-off-by: Giedrius Statkevičius giedrius.statkevicius@vinted.com