cmd/thanos/receive: fix dialopts TLS heuristic #4388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice find 💪 How have you been able to verify this change indeed fixes the problem? I'm not aware of a test that excercises this code path. |
Currently, the Thanos receive gRPC dialopts are configured to use TLS when the remote-write HTTP server is configured with a TLS certificate. This heuristic is not correct: just because the remote-write HTTP server is exposed over TLS does not mean that the hashring gRPC server is using TLS. This commit fixes the heuristic for enabling TLS in the gRPC client for forwarding remote-write requests internally within a hashring. Fixes: thanos-io#4382. Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
bwplotka
approved these changes
Jul 1, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Thanos receive gRPC dialopts are configured to use TLS
when the remote-write HTTP server is configured with a TLS certificate.
This heuristic is not correct: just because the remote-write HTTP server
is exposed over TLS does not mean that the hashring gRPC server is using
TLS. This commit fixes the heuristic for enabling TLS in the gRPC client
for forwarding remote-write requests internally within a hashring.
Fixes: #4382.
Signed-off-by: Lucas Servén Marín lserven@gmail.com