Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go 1.15 #3022

Merged
merged 4 commits into from
Sep 2, 2020
Merged

Upgrade to Go 1.15 #3022

merged 4 commits into from
Sep 2, 2020

Conversation

kakkoyun
Copy link
Member

@kakkoyun kakkoyun commented Aug 12, 2020

Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com

  • I added CHANGELOG entry for this change.

https://golang.org/doc/go1.15#compiler

Go 1.15 reduces typical binary sizes by around 5% compared to Go 1.14 by eliminating certain types of GC metadata and more aggressively eliminating unused type metadata.

1.14.7

Screenshot 2020-08-12 at 10 36 25

1.15.0

Screenshot 2020-08-12 at 10 36 42

Changes

  • Upgrade use go version
  • Upgrade promu version
  • Upgrade CI go version

Verification

  • make build
  • make test-local

@kakkoyun kakkoyun changed the title WIP: Upgrade to Go 1.15 Upgrade to Go 1.15 Aug 31, 2020
@kakkoyun kakkoyun marked this pull request as ready for review August 31, 2020 08:38
@kakkoyun
Copy link
Member Author

Somehow Netlify builds use Go and jobs fail. I couldn't figure where it's specified.

@kakkoyun
Copy link
Member Author

Found the reason of Netlify failures https://github.com/netlify/build-image/blob/450c24b893036c2813a0b0d0a2a05bcdd81935a4/run-build-functions.sh
Netlify uses https://github.com/netlify/gimme to install Go and gimme Go version is listed as 1.15 which is specified in .go-version

# Ignore minikube setup working dirs.
kube/bin
kube/.kube
kube/.minikube
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use Kubernetes in our tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have copied those from .gitignore. I haven't checked them to be honest.

@kakkoyun
Copy link
Member Author

There's a failing test. I need to check the underlying cause.

--- FAIL: TestRoundTripSplitIntervalMiddleware (0.00s)
    --- FAIL: TestRoundTripSplitIntervalMiddleware/split_to_2_requests (0.00s)
        roundtrip_test.go:269: roundtrip_test.go:269:
            
            	exp: 2
            
            	got: 1

@yeya24
Copy link
Contributor

yeya24 commented Aug 31, 2020

There's a failing test. I need to check the underlying cause.

--- FAIL: TestRoundTripSplitIntervalMiddleware (0.00s)
    --- FAIL: TestRoundTripSplitIntervalMiddleware/split_to_2_requests (0.00s)
        roundtrip_test.go:269: roundtrip_test.go:269:
            
            	exp: 2
            
            	got: 1

@kakkoyun Reported here #3084.

I am checking that now. Please ignore this first.

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

@bwplotka bwplotka merged commit df80837 into thanos-io:master Sep 2, 2020
@kakkoyun kakkoyun deleted the upgrade_go115 branch September 2, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants