Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: Refactor API into a new package #2926

Merged
merged 9 commits into from
Jul 30, 2020
Merged

api: Refactor API into a new package #2926

merged 9 commits into from
Jul 30, 2020

Conversation

onprem
Copy link
Member

@onprem onprem commented Jul 22, 2020 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Consolidated the API logic into a new package.
  • Implement API in the Compactor.
  • Add /blocks endpoint to return blocks metadata.
  • Expose the same API from Block Viewer.

Verification

Tested Locally using docker-compose setup.

@onprem
compactor: Implement API endpoint to return data about blocks
3e5b014 
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
@onprem
bucket web: Expose the Compact API for blocks data
d730031 
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
@onprem
api: Refactor the HTTP API into a seperate package
957b239 
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
@onprem
api: Update tests for the new package
90082ba 
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
@onprem onprem changed the title compact: Implement API endpoint to return blocks information api: Refactor API into a new package Jul 28, 2020
@onprem
Fix import order in cmd/rule
34c8895 
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
bwplotka
bwplotka reviewed Jul 28, 2020
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Some comments though. (:

cmd/thanos/compact.go Outdated Show resolved Hide resolved
pkg/api/compact/v1.go Outdated Show resolved Hide resolved
pkg/api/compact/v1.go Outdated Show resolved Hide resolved
@onprem
Rename api/compact to api/blocks
23020c1 
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
@onprem
Create a helper funtion for getting a map of flags
9443d13 
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
@onprem
Add entry in CHANGELOG and fixed linting errors
8d6d9d8 
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
@onprem
Merge branch 'master' into blocks-api
23ca39d 
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
bwplotka
bwplotka approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me, LGTM, but let's wait on @GiedriusS or @squat for final call.

BTW I really would love to look for some hosting which would allow us to run Thanos on every PR and play with the UI (:

GiedriusS
GiedriusS approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome work.

@GiedriusS GiedriusS merged commit 86e4b69 into thanos-io:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS approved these changes

@bwplotka bwplotka bwplotka approved these changes

@squat squat Awaiting requested review from squat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onprem @GiedriusS @bwplotka