tracing: Support sampling on Elastic APM #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes thanos-io#2039 Signed-off-by: Igor Wiedler <iwiedler@gitlab.com>
Signed-off-by: Igor Wiedler <iwiedler@gitlab.com>
igorwwwwwwwwwwwwwwwwwwww
force-pushed
the
elastic-sampling
branch
from
cdba2c1
to
a5924ef
Compare
Signed-off-by: Igor Wiedler <iwiedler@gitlab.com>
igorwwwwwwwwwwwwwwwwwwww
force-pushed
the
elastic-sampling
branch
from
2eb4534
to
0c9fa28
Compare
bwplotka
approved these changes
Jan 27, 2020
|
Managed to verify that this works. Surprisingly, the APM library will still emit empty traces for non-sampled events (basically a root span without children), but that appears to be by design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch to address #2039.
Tracing every request can be quite expensive. By introducing a sample rate (similar to what stackdriver and jaeger already support), the overhead and trace storage cost can be controlled.
This patch adds sampling for Elastic APM tracing.
Changes
sample_ratesettingVerification
0, this will break anyone currently using the elastic APM backend. It might make sense to have a proper default value of1-- this applies to various settings on other tracing backends.