Do not specify paperName for event onInsetsChanged
#476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janicduplessis
approved these changes
Mar 8, 2024
|
Thanks @cortinico ! |
|
cc @brentvatne |
|
@janicduplessis can we get another RC with this fix included? |
|
Sure, will do that today |
|
published as 4.10.0-rc.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Library is currently failing to work on 0.74.0-RC2 due to the library accidentally (?) specifying a paper event name for the
onInsetsChangeevent.The logic in core has changed here: facebook/react-native@76613ec
As the paper event name is not used at all in native code, it's safe to remove entirely.
Test Plan