Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing types for jest/mock #390

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Add missing types for jest/mock #390

merged 1 commit into from
Jun 20, 2023

Conversation

tarunrajput
Copy link
Contributor

Summary

Add missing types for jest/mock

Test Plan

yarn test
yarn validate:typescript

@jacobp100
Copy link
Collaborator

Sorry for missing this. Looks good - thanks for the PR

@janicduplessis janicduplessis merged commit c4f7ca8 into th3rdwave:main Jun 20, 2023
@tarunrajput tarunrajput mentioned this pull request Jun 21, 2023
Closed
@bradfloodx
Copy link

Hi @janicduplessis and thanks.

Was this released in 4.6.0? I see this was merged before you released today, but I'm not seeing it in the change log though I am now running into Could not find a declaration file for module 'react-native-safe-area-context'. error after upgrading to 4.6.0. I'm still investigating.

Cheers!

@tarunrajput
Copy link
Contributor Author

@bradleyflood, someone already opened a PR (#400)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janicduplessis janicduplessis janicduplessis approved these changes

@jacobp100 jacobp100 jacobp100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tarunrajput @jacobp100 @bradfloodx @janicduplessis