Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge example apps, update deps #380

Merged
merged 9 commits into from
Apr 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 28 additions & 12 deletions .github/workflows/android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,26 +9,24 @@ on:
- 'android/**'
- 'common/**'
- 'example/android/**'
- 'fabric-example/android/**'
pull_request:
paths:
- '.github/workflows/android.yml'
- 'android/**'
- 'example/android/**'
- 'fabric-example/android/**'

jobs:
android-build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- name: Use Node.js 16.x
uses: actions/setup-node@v1
- uses: actions/checkout@v3
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: Restore yarn workspaces
id: yarn-cache
uses: actions/cache@v2
uses: actions/cache@v3
with:
path: |
node_modules
Expand All @@ -42,9 +40,27 @@ jobs:
- name: Build android example app
run: ./gradlew assembleDebug
working-directory: example/android
- name: Install fabric example app dependencies
android-build-fabric:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Use Node.js 18.x
uses: actions/setup-node@v1
with:
node-version: 18.x
- name: Restore yarn workspaces
id: yarn-cache
uses: actions/cache@v3
with:
path: |
node_modules
*/*/node_modules
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
- name: Install dependencies
run: yarn install
working-directory: fabric-example
- name: Build android example app
run: ./gradlew assembleDebug
working-directory: fabric-example/android
- name: Install example app dependencies
run: yarn install
working-directory: example
- name: Build android example app with new arch enabled
run: ./gradlew assembleDebug -PnewArchEnabled=true
working-directory: example/android
53 changes: 30 additions & 23 deletions .github/workflows/ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,48 +9,55 @@ on:
- 'ios/**'
- 'common/**'
- 'example/ios/**'
- 'fabric-example/ios/**'
pull_request:
paths:
- '.github/workflows/ios.yml'
- 'ios/**'
- 'example/ios/**'
- 'fabric-example/ios/**'
jobs:
ios-build:
runs-on: macos-latest
steps:
- uses: actions/checkout@v1
- name: Use Node.js 16.x
uses: actions/setup-node@v1
- uses: actions/checkout@v3
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 18.x
- uses: ruby/setup-ruby@v1
with:
node-version: 16.x
working-directory: example
bundler-cache: true
- name: Install dependencies
run: yarn install
- name: Install example app dependencies
run: yarn install
working-directory: example
- name: Install example app dependencies
run: yarn install
working-directory: example
- name: Install example app gems
run: bundle install
working-directory: example
- name: Install pods
run: bundle exec pod install
working-directory: example/ios
- name: Build ios example app
run: xcodebuild -scheme SafeAreaViewExample -workspace SafeAreaViewExample.xcworkspace ONLY_ACTIVE_ARCH=NO -sdk iphonesimulator -configuration Debug
run: xcodebuild -scheme FabricExample -workspace FabricExample.xcworkspace ONLY_ACTIVE_ARCH=NO -sdk iphonesimulator -configuration Debug
working-directory: example/ios
- name: Install fabric example app dependencies
ios-build-fabric:
runs-on: macos-latest
steps:
- uses: actions/checkout@v3
- name: Use Node.js 18.x
uses: actions/setup-node@v1
with:
node-version: 18.x
- uses: ruby/setup-ruby@v1
with:
working-directory: example
bundler-cache: true
- name: Install dependencies
run: yarn install
working-directory: fabric-example
- name: Install fabric example app gems
run: bundle install
working-directory: fabric-example
- name: Install fabric pods
run: bundle exec pod install
working-directory: fabric-example/ios
- name: Build ios fabric example app
- name: Install example app dependencies
run: yarn install
working-directory: example
- name: Install pods for new arch
run: RCT_NEW_ARCH_ENABLED=1 bundle exec pod install
working-directory: example/ios
- name: Build ios example app
run: xcodebuild -scheme FabricExample -workspace FabricExample.xcworkspace ONLY_ACTIVE_ARCH=NO -sdk iphonesimulator -configuration Debug
working-directory: fabric-example/ios
working-directory: example/ios
10 changes: 5 additions & 5 deletions .github/workflows/js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@ jobs:
js-tests:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- name: Use Node.js 16.x
uses: actions/setup-node@v1
- uses: actions/checkout@v3
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: Restore yarn workspaces
id: yarn-cache
uses: actions/cache@v2
uses: actions/cache@v3
with:
path: |
node_modules
Expand Down
File renamed without changes.
25 changes: 14 additions & 11 deletions example/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ DerivedData
*.hmap
*.ipa
*.xcuserstate
project.xcworkspace
ios/.xcode.env.local

# Android/IntelliJ
#
Expand All @@ -29,32 +29,35 @@ build/
.gradle
local.properties
*.iml
*.hprof
.cxx/
*.keystore
!debug.keystore

# node.js
#
node_modules/
npm-debug.log
yarn-error.log

# BUCK
buck-out/
\.buckd/
*.keystore
!debug.keystore

# fastlane
#
# It is recommended to not store the screenshots in the git repo. Instead, use fastlane to re-generate the
# screenshots whenever they are needed.
# For more information about the recommended setup visit:
# https://docs.fastlane.tools/best-practices/source-control/

*/fastlane/report.xml
*/fastlane/Preview.html
*/fastlane/screenshots
**/fastlane/report.xml
**/fastlane/Preview.html
**/fastlane/screenshots
**/fastlane/test_output

# Bundle artifact
*.jsbundle

# CocoaPods
# Ruby / CocoaPods
/ios/Pods/
/vendor/bundle/

# Temporary files created by Metro to check the health of the file watcher
.metro-health-check*
File renamed without changes.
File renamed without changes.
5 changes: 4 additions & 1 deletion example/Gemfile
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
source 'https://rubygems.org'

gem 'cocoapods', '~> 1.11', '>= 1.11.2'
# You may use http://rbenv.org/ or https://rvm.io/ to install and use this version
ruby File.read(File.join(__dir__, '.ruby-version')).strip

gem 'cocoapods', '~> 1.11', '>= 1.11.3'
97 changes: 0 additions & 97 deletions example/Gemfile.lock

This file was deleted.

Loading