Skip to content

Commit

Permalink
fix: ts
Browse files Browse the repository at this point in the history
  • Loading branch information
janicduplessis committed Jun 21, 2023
1 parent def6c1f commit 7ed701b
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/SafeArea.types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import NativeSafeAreaView from './specs/NativeSafeAreaView';
export type Edge = 'top' | 'right' | 'bottom' | 'left';
export type EdgeMode = 'off' | 'additive' | 'maximum';

export type EdgeRecord = Partial<Readonly<Record<Edge, EdgeMode>>>;
export type Edges = readonly Edge[] | EdgeRecord;
export type EdgeRecord = Partial<Record<Edge, EdgeMode>>;
export type Edges = readonly Edge[] | Readonly<EdgeRecord>;

export interface EdgeInsets {
top: number;
Expand Down
5 changes: 3 additions & 2 deletions src/SafeAreaView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,12 @@ export const SafeAreaView = React.forwardRef<
}

const edgesObj = Array.isArray(edges)
? edges.reduce<EdgeRecord>((acc, edge) => {
? edges.reduce<EdgeRecord>((acc, edge: Edge) => {
acc[edge] = 'additive';
return acc;
}, {})
: edges;
: // ts has trouble with refining readonly arrays.
(edges as EdgeRecord);

// make sure that we always pass all edges, required for fabric
const requiredEdges: Record<Edge, EdgeMode> = {
Expand Down
7 changes: 5 additions & 2 deletions src/SafeAreaView.web.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,12 @@ export const SafeAreaView = React.forwardRef<
const edgeBitmask =
edges != null
? Array.isArray(edges)
? edges.reduce((accum, edge) => accum | edgeBitmaskMap[edge], 0)
? edges.reduce(
(acc: number, edge: Edge) => acc | edgeBitmaskMap[edge],
0,
)
: Object.keys(edges).reduce(
(accum, edge) => accum | edgeBitmaskMap[edge as Edge],
(acc, edge) => acc | edgeBitmaskMap[edge as Edge],
0,
)
: ALL;
Expand Down

0 comments on commit 7ed701b

Please sign in to comment.