Upstream v2.49.0 #22
Open
Upstream v2.49.0 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checking replaces the config processing for bor sprints which has the following issues: 1. It uses string ordering for blocks which is lexical so does not handle decimal scale when sorting numbers 2. It parses the config map every calculation - which is expensive relative to just checking the index order This is likely not an issue for the existing main net as the map only has 2 entries and their sort order is coincidentally the same for both lexical and numeric ordering. Performance is likely also a non issue compared to the other processing during execution flow. These changes are intended to support tx indexing where in the snapshotting process the calc will get called at least twice for each bor block during 1000's of iterations.
Add a bound the txpool db, rather than leaving it as the default of 2TB. This is to reduce the page file profile when running multiple nodes from around 3.5GB per txpool instance. The current pool map side is set to 512MB - which seems reasonable with 16MB increments
Reverts ledgerwatch#1050 It causes the error: `EROR[07-21|21:45:02.806] [txpool] flush is local history err="table: PoolTransaction, err: mdbx_cursor_put: MDBX_MAP_FULL: Environment mapsize limit reached" `
Fixes the following panic triggered by blob Hive tests: ``` [2c098836] panic: runtime error: index out of range [0] with length 0 [2c098836] [2c098836] goroutine 902 [running]: [2c098836] github.com/ledgerwatch/erigon-lib/txpool.MainLoop.func1() [2c098836] github.com/ledgerwatch/erigon-lib@v0.0.0-20230801100033-1b342f37741d/txpool/pool.go:1565 +0x100f [2c098836] created by github.com/ledgerwatch/erigon-lib/txpool.MainLoop [2c098836] github.com/ledgerwatch/erigon-lib@v0.0.0-20230801100033-1b342f37741d/txpool/pool.go:1492 +0x8c5 ```
Co-authored-by: Alex Sharp <alexsharp@Alexs-MacBook-Pro-2.local>
Added ``` MdbxPageSize datasize.ByteSize MdbxDBSizeLimit datasize.ByteSize MdbxGrowthStep datasize.ByteSize ``` to allow txpool db to be configured.
Less radical variant of PR ledgerwatch#1094
pcw109550
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream sync PR
erigon
ledgerwatch/erigonv2.49.0 ->testinprod-io/op-erigondd556a8erigon-lib
ledgerwatch/erigon-libdde477f ->testinprod-io/erigon-libb7b8746erigon-interfaces
ledgerwatch/interfaces1fb30d8 ->testinprod-io/erigon-interfacesf2e7a04