This repository has been archived by the owner on Sep 23, 2023. It is now read-only.
Parse EIP-4844 transactions wrapped with blobs #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
racytech
approved these changes
Jul 10, 2023
|
Perhaps this is going to be in a future CL but I don't see yet any checks that verify the blob wrapper validity (e.g. num-blobs == num-blob-hashes == num-commitments == num-proofs, and that the proofs match) Otherwise LGTM |
That's right, we need to do the checks in a subsequent PR. |
yperbasis
added a commit
to erigontech/erigon
that referenced
this pull request
Jul 11, 2023
Small refactoring after ledgerwatch/erigon-lib#1037
calmbeing
pushed a commit
to calmbeing/bsc-erigon-lib
that referenced
this pull request
Jul 12, 2023
AskAlexSharov
pushed a commit
that referenced
this pull request
Sep 6, 2023
Continuation of PR #1034
AskAlexSharov
pushed a commit
to erigontech/erigon
that referenced
this pull request
Sep 6, 2023
Small refactoring after ledgerwatch/erigon-lib#1037
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of PR #1034