-
Notifications
You must be signed in to change notification settings - Fork 93
Conversation
8993711
to
f16379f
Compare
merge devel plz |
8ae3d6a
to
c5046cf
Compare
done, build all good now! |
9e28f16
to
2090fc9
Compare
go.mod
Outdated
@@ -106,3 +109,5 @@ require ( | |||
google.golang.org/genproto v0.0.0-20221118155620-16455021b5e6 // indirect | |||
gopkg.in/yaml.v3 v3.0.1 // indirect | |||
) | |||
|
|||
replace github.com/ledgerwatch/interfaces => github.com/roberto-bayardo/interfaces v0.0.0-20230125140013-a42dd5f11cb5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a PR against ledgerwatch/interfaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f4fdd9c
to
2b1ed1f
Compare
w.sigHashEnd = end | ||
originalBegin := begin | ||
var err error | ||
w.chainID, err = readUint256(payload, begin) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess this is ssz and we can move this helper func to erigon-lib/ssz
package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes there's a lot of ssz stuff that should be migrated or made to use erigon-lib/ssz. I can look into this next week if someone hasn't started on it already.
61a95ea
to
c89467f
Compare
c89467f
to
af6d929
Compare
fda051f
to
6118d6e
Compare
6118d6e
to
2f886fc
Compare
5835fd5
to
b0e3786
Compare
Merged with upstream. Blob tx tests are currently failing since the blob tx format is out of date and doesn't pass current verification rules, but since we are converting to RLP probably not worth fixing? |
cc: @yperbasis |
dd9304d
to
71b58ee
Compare
71b58ee
to
1340b60
Compare
Reworked bits of PR #850. Only stubs for transaction parsing.
Reworked bits of PR ledgerwatch#850. Only stubs for transaction parsing.
Reworked bits of PR ledgerwatch#850. Only stubs for transaction parsing.
Reworked bits of PR #850. Only stubs for transaction parsing.
No description provided.