Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Move key event behavior from
src/keyboard/plugins
tosrc/event/behavior
.Dispatch
beforeinput
events, so that the event handlers can cancel changes to the DOM.Fix missing
click
events when pressing[Enter]
in a form that has at least one submit button.Why:
Hopefully the new code will be easier to understand and maintain.
beforeinput
events were missing and therefore event handlers for them had no effect.When
[Enter]
is pressed on an<input>
element inside a form and there is at least one submit button, that button receives aclick
event.How:
Refactor all implementations for modifying the DOM into one central
input()
util function.Refactor all default behavior for key events into
src/event
.Drive-by fix of the
keypress
implementation for[Enter]
.Checklist: