feat(toHaveValue): Asserting aria-valuenow #479
Conversation
src/utils.js
Outdated
| return element.value | ||
| default: { | ||
| const accessibleValue = getAccessibleValue(element) | ||
| return element.value ?? accessibleValue |
There was a problem hiding this comment.
@idanen Which should have precedence, value or aria-valuenow? At the moment it looks like the former has precedence.
There was a problem hiding this comment.
value should take precedence.
That's how Chrome's accessibility tab behaves
|
@gnapse @nickmccurdy any chance one of you can help push this forward? |
Co-authored-by: Wayne Van Son <waynevanson@gmail.com>
idanen
force-pushed
the
pr/to-have-aria-value
branch
from
ee8c49c
to
706a94b
Compare
Head branch was pushed to by a user without write access
|
@gnapse finally fixed the coverage. Can you please give it another look? |
|
@all-contributors please add @idanen for code, test |
|
I've put up a pull request to add @idanen! 🎉 |
|
@all-contributors please add @waynevanson for code, test |
|
I've put up a pull request to add @waynevanson! 🎉 |
|
@all-contributors please add @waynevanson for code, test |
|
@waynevanson already contributed before to code, test |
|
🎉 This PR is included in version 6.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves #478
What:
Change
.toHaveValue()to supportaria-valuenowWhy:
How:
Checklist: