Publish both esm and cjs

[IanVS]

What:

This publishes both es modules and commonjs in the bundle.

Why:

Closes #437

How:

I used rollup to generate the two sets of bundles. I'm not doing any processing on either of them aside from what rollup does by default, mostly because I'm not sure what level of browser/node support this project follows. It would be pretty straightforward to add https://www.npmjs.com/package/@rollup/plugin-babel or otherwise configure the output as needed.

Checklist:

• Documentation
• Tests
• Updated Type Definitions
• Ready to be merged
  

I haven't updated any documentation or tests, because I wanted to see if this was at all on the right track.

[codecov]

Codecov Report

Merging #438 (cf540f4) into main (4d0ceeb) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #438   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          624       624           
  Branches       231       231           
=========================================
  Hits           624       624           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d0ceeb...cf540f4. Read the comment docs.

[IanVS]

To be safe, maybe this could be released along with #379 in a major version bump.

[gnapse]

To be safe, maybe this could be released along with #379 in a major version bump.

Ok. I'll do it that way. So for now I'll merge this onto the next branch, so it does not get auto-released. I'll then merge #379 to next too, so that I trigger a single release when I push this all to main.

One thing I wanted to ask you about: what are the chances for surprises when this gets released? I ask because I'm a bit nervous that this cannot be tested locally? Or can it? Can I test somehow how this would work as if it was installed via npm, but without the release existing yet? Have you tested it in this way somehow?

[IanVS]

@gnapse I have tested in my own vite storybook app, by running npm build, and copying the package.json and dist over to my project's node_modules.

I don't have a traditional jest project running in node to test the cjs build on, but the process would be the same.

Perhaps you could publish an alpha or beta version, that people could test out?

[IanVS]

@gnapse do you still plan to release a beta version with this change? Is there anything else you'd like me to do before you're comfortable with it?

[gnapse]

@IanVS sorry for the delay. I'm going to resume work on this tomorrow. I'll decide then if I go with a alpha or beta version first.

[yannbf]

Thank you all for doing this! I was wondering whether there are plans to release this in an alpha version somewhere?

Thank you <3

[IanVS]

Hi is there any plan to release this? It's kind of a bummer that I put the work into it and there's still no way to use it.

[yannbf]

Hey @gnapse was this change ever included in a release?

[kasperpeulen]

Can this PR also be merged to main?

[IanVS]

It looks like the other changes that were in next were cherry-picked back to main and released, but not this one. Does anyone have any information why? It would be great to publish ESM, if at all possible.

[IanVS]

OK, I see now this needs to be reworked a bit based on the multiple export paths now supported for vitest, etc. I'll open a new PR. Edit: #519