Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update aria-query to 5.0.0 #414

Merged
merged 4 commits into from
Dec 3, 2021

Conversation

IanVS
Copy link
Contributor

@IanVS IanVS commented Oct 15, 2021

What:

This updates the version of aria-query to 5.0.0.

Why:

Closes #413.

How:

This is a breaking change in that Map and Set are no longer used. But, the roles object that is returned has methods on it, including .get(), which is used in roleSupportsChecked.

The only update I made to the code is to remove the Array.from() call, since roles.keys() already returns an array now.

Checklist:

  • Documentation N/A
  • Tests
  • Updated Type Definitions N/A
  • Ready to be merged

@IanVS
Copy link
Contributor Author

IanVS commented Nov 8, 2021

Hi, the corresponding PR was merged into dom-testing-library. Would anyone like to take a look at this PR? I think it's best if the versions stay in-sync.

@gnapse
Copy link
Member

gnapse commented Dec 3, 2021

To confirm what you seem to say in the PR description: is this a breaking change to the outside world?

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #414 (677ca29) into main (dfcefa2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #414   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          620       620           
  Branches       227       227           
=========================================
  Hits           620       620           
Impacted Files Coverage Δ
src/to-be-checked.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfcefa2...677ca29. Read the comment docs.

@IanVS
Copy link
Contributor Author

IanVS commented Dec 3, 2021

I do not believe this is breaking, and a major release was not needed for dom-testing-library, see: testing-library/dom-testing-library#1058 (comment)

@gnapse gnapse merged commit de26c7a into testing-library:main Dec 3, 2021
@gnapse
Copy link
Member

gnapse commented Dec 3, 2021

@all-contributors please add @IanVS for code

@allcontributors
Copy link
Contributor

@gnapse

I've put up a pull request to add @IanVS! 🎉

@gnapse gnapse changed the title Update aria-query to 5.0.0 feat: Update aria-query to 5.0.0 Dec 3, 2021
@IanVS
Copy link
Contributor Author

IanVS commented Dec 3, 2021

Thanks @gnapse!

@IanVS IanVS deleted the update-aria-query branch December 3, 2021 21:09
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

🎉 This PR is included in version 5.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update aria-query to avoid babel runtime
2 participants