fix(prefer-explicit-assert): handle valid getBy* without expect (#257)

testing-library · Nov 18, 2020 · b289638 · b289638
1 parent e74c215
commit b289638
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/rules/prefer-explicit-assert.ts b/lib/rules/prefer-explicit-assert.ts
@@ -95,6 +95,7 @@ export default ESLintUtils.RuleCreator(getDocsUrl)<Options, MessageIds>({
             });
           } else if (assertion) {
             const expectCallNode = findClosestCallNode(node, 'expect');
+            if (!expectCallNode) return;
 
             const expectStatement = expectCallNode.parent as TSESTree.MemberExpression;
             const property = expectStatement.property as TSESTree.Identifier;

diff --git a/tests/lib/rules/prefer-explicit-assert.test.ts b/tests/lib/rules/prefer-explicit-assert.test.ts
@@ -67,7 +67,9 @@ ruleTester.run(RULE_NAME, rule, {
       code: `queryByText("foo")`,
     },
     {
-      code: `expect(getByText('foo')).toBeTruthy()`,
+      code: `expect(getByText('foo')).toBeTruthy()
+      
+      fireEvent.click(getByText('bar'));`,
       options: [
         {
           assertion: 'toBeTruthy',