chore: update dependencies + run prettier on codebase (#232)

* chore: update dependencies * chore: run Prettier on full codebase
testing-library · Sep 20, 2020 · 3c77c85 · 3c77c85
1 parent e79c0e5
commit 3c77c85
Show file tree

Hide file tree

Showing 9 changed files with 228 additions and 14,949 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,4 +1,4 @@
-# Output 
+# Output
 dist
 
 # Logs
@@ -66,3 +66,8 @@ yarn-error.log
 .pnp.js
 # Yarn Integrity file
 .yarn-integrity
+
+# these cause more harm than good
+# when working with contributors
+package-lock.json
+yarn.lock
diff --git a/commitlint.config.js b/commitlint.config.js
@@ -1 +1,3 @@
-module.exports = { extends: ['@commitlint/config-conventional'] };
+module.exports = {
+  extends: ['@commitlint/config-conventional'],
+};
diff --git a/lib/node-utils.ts b/lib/node-utils.ts
@@ -1,4 +1,7 @@
-import { AST_NODE_TYPES, TSESTree } from '@typescript-eslint/experimental-utils';
+import {
+  AST_NODE_TYPES,
+  TSESTree,
+} from '@typescript-eslint/experimental-utils';
 import { RuleContext } from '@typescript-eslint/experimental-utils/dist/ts-eslint';
 
 export function isCallExpression(
@@ -84,7 +87,7 @@ export function findClosestCallExpressionNode(
     return node;
   }
 
-  if(!node.parent) return null
+  if (!node.parent) return null;
 
   return findClosestCallExpressionNode(node.parent);
 }
@@ -108,8 +111,10 @@ export function findClosestCallNode(
   }
 }
 
-export function isObjectExpression(node: TSESTree.Expression): node is TSESTree.ObjectExpression {
-  return node?.type === AST_NODE_TYPES.ObjectExpression
+export function isObjectExpression(
+  node: TSESTree.Expression
+): node is TSESTree.ObjectExpression {
+  return node?.type === AST_NODE_TYPES.ObjectExpression;
 }
 
 export function hasThenProperty(node: TSESTree.Node) {
@@ -126,16 +131,24 @@ export function isAwaitExpression(
   return node && node.type === AST_NODE_TYPES.AwaitExpression;
 }
 
-export function isArrowFunctionExpression(node: TSESTree.Node): node is TSESTree.ArrowFunctionExpression {
-  return node && node.type === AST_NODE_TYPES.ArrowFunctionExpression
+export function isArrowFunctionExpression(
+  node: TSESTree.Node
+): node is TSESTree.ArrowFunctionExpression {
+  return node && node.type === AST_NODE_TYPES.ArrowFunctionExpression;
 }
 
-export function isReturnStatement(node: TSESTree.Node): node is TSESTree.ReturnStatement {
-  return node && node.type === AST_NODE_TYPES.ReturnStatement
+export function isReturnStatement(
+  node: TSESTree.Node
+): node is TSESTree.ReturnStatement {
+  return node && node.type === AST_NODE_TYPES.ReturnStatement;
 }
 
 export function isAwaited(node: TSESTree.Node) {
-  return isAwaitExpression(node) || isArrowFunctionExpression(node) || isReturnStatement(node)
+  return (
+    isAwaitExpression(node) ||
+    isArrowFunctionExpression(node) ||
+    isReturnStatement(node)
+  );
 }
 
 export function isPromiseResolved(node: TSESTree.Node) {
@@ -150,6 +163,13 @@ export function isPromiseResolved(node: TSESTree.Node) {
   return hasThenProperty(parent);
 }
 
-export function getVariableReferences(context: RuleContext<string, []>, node: TSESTree.Node) {
-  return (isVariableDeclarator(node) && context.getDeclaredVariables(node)[0].references.slice(1)) || [];
-}
+export function getVariableReferences(
+  context: RuleContext<string, []>,
+  node: TSESTree.Node
+) {
+  return (
+    (isVariableDeclarator(node) &&
+      context.getDeclaredVariables(node)[0].references.slice(1)) ||
+    []
+  );
+}
diff --git a/lib/rules/no-debug.ts b/lib/rules/no-debug.ts
@@ -14,9 +14,7 @@ import {
 
 export const RULE_NAME = 'no-debug';
 export type MessageIds = 'noDebug';
-type Options = [
-  { renderFunctions?: string[]; }
-];
+type Options = [{ renderFunctions?: string[] }];
 
 function isRenderVariableDeclarator(
   node: TSESTree.VariableDeclarator,

diff --git a/lib/rules/prefer-screen-queries.ts b/lib/rules/prefer-screen-queries.ts
@@ -13,12 +13,23 @@ export const RULE_NAME = 'prefer-screen-queries';
 export type MessageIds = 'preferScreenQueries';
 type Options = [];
 
-const ALLOWED_RENDER_PROPERTIES_FOR_DESTRUCTURING = ['container', 'baseElement']
+const ALLOWED_RENDER_PROPERTIES_FOR_DESTRUCTURING = [
+  'container',
+  'baseElement',
+];
 const ALL_QUERIES_COMBINATIONS_REGEXP = ALL_QUERIES_COMBINATIONS.join('|');
 
 function usesContainerOrBaseElement(node: TSESTree.CallExpression) {
-  const secondArgument = node.arguments[1]
-  return isObjectExpression(secondArgument) && secondArgument.properties.some((property) => isProperty(property) && isIdentifier(property.key) && ALLOWED_RENDER_PROPERTIES_FOR_DESTRUCTURING.includes(property.key.name))
+  const secondArgument = node.arguments[1];
+  return (
+    isObjectExpression(secondArgument) &&
+    secondArgument.properties.some(
+      property =>
+        isProperty(property) &&
+        isIdentifier(property.key) &&
+        ALLOWED_RENDER_PROPERTIES_FOR_DESTRUCTURING.includes(property.key.name)
+    )
+  );
 }
 
 export default ESLintUtils.RuleCreator(getDocsUrl)<Options, MessageIds>({
@@ -53,33 +64,43 @@ export default ESLintUtils.RuleCreator(getDocsUrl)<Options, MessageIds>({
     const queriesRegex = new RegExp(ALL_QUERIES_COMBINATIONS_REGEXP);
     const queriesDestructuredInWithinDeclaration: string[] = [];
     // use an array as within might be used more than once in a test
-    const withinDeclaredVariables : string[] = []
+    const withinDeclaredVariables: string[] = [];
 
     return {
       VariableDeclarator(node) {
         if (!isCallExpression(node.init) || !isIdentifier(node.init.callee)) {
-          return
+          return;
         }
-        const isWithinFunction =  node.init.callee.name === 'within';
+        const isWithinFunction = node.init.callee.name === 'within';
         // TODO add the custom render option #198
-        const usesRenderOptions = node.init.callee.name === 'render' && usesContainerOrBaseElement(node.init);
+        const usesRenderOptions =
+          node.init.callee.name === 'render' &&
+          usesContainerOrBaseElement(node.init);
 
         if (!isWithinFunction && !usesRenderOptions) {
-          return
+          return;
         }
 
         if (isObjectPattern(node.id)) {
           // save the destructured query methods
           const identifiers = node.id.properties
-            .filter(property => isProperty(property) && isIdentifier(property.key) && queriesRegex.test(property.key.name))
-            .map((property: TSESTree.Property) => (property.key as TSESTree.Identifier).name);
+            .filter(
+              property =>
+                isProperty(property) &&
+                isIdentifier(property.key) &&
+                queriesRegex.test(property.key.name)
+            )
+            .map(
+              (property: TSESTree.Property) =>
+                (property.key as TSESTree.Identifier).name
+            );
 
           queriesDestructuredInWithinDeclaration.push(...identifiers);
-          return
+          return;
         }
 
         if (isIdentifier(node.id)) {
-          withinDeclaredVariables.push(node.id.name)
+          withinDeclaredVariables.push(node.id.name);
         }
       },
       [`CallExpression > Identifier[name=/^${ALL_QUERIES_COMBINATIONS_REGEXP}$/]`](
@@ -96,18 +117,18 @@ export default ESLintUtils.RuleCreator(getDocsUrl)<Options, MessageIds>({
       [`MemberExpression > Identifier[name=/^${ALL_QUERIES_COMBINATIONS_REGEXP}$/]`](
         node: TSESTree.Identifier
       ) {
-
         function isIdentifierAllowed(name: string) {
-          return ['screen', ...withinDeclaredVariables].includes(name)
+          return ['screen', ...withinDeclaredVariables].includes(name);
         }
 
         if (
           isIdentifier(node) &&
           isMemberExpression(node.parent) &&
           isCallExpression(node.parent.object) &&
-          isIdentifier(node.parent.object.callee) && 
-          node.parent.object.callee.name !== 'within' && 
-          node.parent.object.callee.name === 'render' && !usesContainerOrBaseElement(node.parent.object)
+          isIdentifier(node.parent.object.callee) &&
+          node.parent.object.callee.name !== 'within' &&
+          node.parent.object.callee.name === 'render' &&
+          !usesContainerOrBaseElement(node.parent.object)
         ) {
           reportInvalidUsage(node);
           return;
@@ -123,4 +144,4 @@ export default ESLintUtils.RuleCreator(getDocsUrl)<Options, MessageIds>({
       },
     };
   },
-});
+});