Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use ARIA 1.2 for role queries #1058

Merged
merged 3 commits into from
Oct 18, 2021
Merged

feat: Use ARIA 1.2 for role queries #1058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1421081
Update aria-query to 5.0.0
IanVS Oct 15, 2021
ce42cbd
Add tests for `term` and `definition` roles
eps1lon Oct 18, 2021
894b685
Add tests for `banner` role
eps1lon Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"@babel/code-frame": "^7.10.4",
"@babel/runtime": "^7.12.5",
"@types/aria-query": "^4.2.0",
"aria-query": "^4.2.2",
"aria-query": "^5.0.0",
"chalk": "^4.1.0",
"dom-accessibility-api": "^0.5.6",
"lz-string": "^1.4.4",
Expand Down
16 changes: 16 additions & 0 deletions src/__tests__/__snapshots__/role-helpers.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,5 +200,21 @@ Name "":
data-testid="a-textarea"
/>

--------------------------------------------------
term:

Name "":
<dt
data-testid="a-dt"
/>

--------------------------------------------------
definition:

Name "":
<dd
data-testid="a-dd"
/>

--------------------------------------------------
`;
16 changes: 16 additions & 0 deletions src/__tests__/role-helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ afterEach(() => {

function setup() {
const {getByTestId} = render(`
<header data-testid="a-header">Banner header</header>
<section aria-label="a region" data-testid='named-section'>
<a href="http://whatever.com" data-testid="a-link">link</a>
<a>invalid link</a>
Expand Down Expand Up @@ -66,6 +67,10 @@ function setup() {
<form data-testid="a-form" />
<section data-testid="a-section" />
</article>
<dl>
<dt data-testid="a-dt">Term</dt>
<dd data-testid="a-dd">Definition</dd>
</dl>
</section>
`)

Expand Down Expand Up @@ -99,6 +104,9 @@ function setup() {
input: getByTestId('a-input-1'),
input2: getByTestId('a-input-2'),
textarea: getByTestId('a-textarea'),
dt: getByTestId('a-dt'),
dd: getByTestId('a-dd'),
header: getByTestId('a-header'),
}
}

Expand Down Expand Up @@ -131,6 +139,9 @@ test('getRoles returns expected roles for various dom nodes', () => {
textarea,
namedSection,
namedForm,
dd,
dt,
header,
} = setup()

expect(getRoles(namedSection)).toEqual({
Expand All @@ -150,6 +161,11 @@ test('getRoles returns expected roles for various dom nodes', () => {
menuitem: [menuItem, menuItem2],
form: [namedForm],
region: [namedSection],
term: [dt],
definition: [dd],
})
expect(getRoles(header)).toEqual({
banner: [header],
})
})

Expand Down