Check for ERROR status after server create #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After create_server returns check for an ERROR status and raise an exception. Since the ERROR state is unrecoverable there is no need to wait for glance_cache_wait_timeout to expire. Signed-off-by: Dean Troyer <dtroyer@gmail.com>
ramereth
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After create_server returns check for an ERROR status and raise an exception. Since the ERROR state is unrecoverable there is no need to wait for glance_cache_wait_timeout to expire. glance_cache_wait_timeout is usually set to higher values than the other timeouts used with the OpenStack API. In CI scenarios where server create failures are more painful due to volume this change eliminates most of this wait time and allows the CI job to enter its retry logic sooner.
Issues Resolved
n/a
Check List
New functionality has been documented in the README if applicable.