Fix issue #117 #136
Merged
Fix issue #117 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would have liked to have added some integration tests to ensure that such regressions don't happen again in the future, but I'm unsure of the best approach since the repository doesn't currently have any integration tests at all. I may spend some time looking at other Kitchen driver repositories to see if/how they have solved this problem. |
gsreynolds
approved these changes
May 6, 2020
There was a problem hiding this comment.
Looks good to me 👍. I've reviewed, built the gem locally and tested it. Resolves #117 and user_assigned_identities: now works as expected.
xorima
approved these changes
May 6, 2020
|
Thanks @zanecodes |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows Azure user assigned identities to be added to the Kitchen instance again, fixing issue #117
Issues Resolved
#117
Check List