lib: provisioning error handling #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to write tests for this but keygen is basically impossible to stub with sinon. So, instead of this I confirmed that the existing behavior is not broken, by walking through the following smoke tests:
Everything worked as expected |
rwaldron
added a commit
that referenced
this pull request
Jul 17, 2015
lib: provisioning error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error handling in provisioning was missing some errors which caused problems in tessel/t2-vm#24 (comment).
feross/standard has a rule that detects when you are not handling the
errparameter in a callback. It's plenty useful, we should have something similar (or maybe switch to standard 👍).