Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move to pyproject.toml #490

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

move to pyproject.toml #490

wants to merge 4 commits into from

Conversation

cmacdonald
Copy link
Contributor

@cmacdonald cmacdonald commented Sep 25, 2024 •
edited
Loading

closes: #489

  • how to override version for test releases to pypi
  • update wiki on how to do a release

@cmacdonald cmacdonald marked this pull request as draft September 25, 2024 10:49
@seanmacavaney
Copy link
Collaborator

how to override version for test releases to pypi

Perhaps sed __init__.py to modify the version in the source?

@cmacdonald
Copy link
Contributor Author

Perhaps sed __init__.py to modify the version in the source?

Thanks for the hint. This was somehow easier than trying to rewrite a the toml file, or find a way to override it.

cmacdonald
cmacdonald commented Sep 25, 2024
View reviewed changes
pyproject.toml
version = {attr = "pyterrier.__version__"}
dependencies = {file = ["requirements.txt"]}

#package_data={'': ['LICENSE.txt', 'requirements.txt', 'requirements-test.txt']}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these included?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need requirements.txt included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmacavaney seanmacavaney Awaiting requested review from seanmacavaney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pyproject.toml
2 participants
@cmacdonald @seanmacavaney