Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query_toks support for terrier.Retriever #466

Merged
merged 8 commits into from
Aug 23, 2024
Merged

query_toks support for terrier.Retriever #466

merged 8 commits into from
Aug 23, 2024

Conversation

cmacdonald
Copy link
Contributor

@cmacdonald cmacdonald commented Aug 20, 2024 •
edited
Loading

{WIP}.

  • Need to be implemented for FBR too.

@cmacdonald
Copy link
Contributor Author

We need to update terrier-retrieval.rst documentation with something on pretokenised.

@cmacdonald
Copy link
Contributor Author

I've added the relevant documentation, @seanmacavaney could you give a quick look.

seanmacavaney
seanmacavaney approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@seanmacavaney seanmacavaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied two minor changes (one to documentation and one to a comment)

besides that lgtm

@cmacdonald cmacdonald merged commit bcf3819 into master Aug 23, 2024
17 checks passed
@cmacdonald cmacdonald deleted the tr_querytoks branch August 23, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmacavaney seanmacavaney seanmacavaney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmacdonald @seanmacavaney