Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pt.java #447

Merged
merged 161 commits into from
Aug 16, 2024
Merged

pt.java #447

merged 161 commits into from
Aug 16, 2024

Conversation

seanmacavaney
Copy link
Collaborator

WIP. Draft pull request for now (to get GH action testing).

@cmacdonald
Copy link
Contributor

Perhaps java/ is a sub-folder? And we put mavenresolver etc in there?

@cmacdonald
Copy link
Contributor

Does jnius remain a declared dependency?

@seanmacavaney
Copy link
Collaborator Author

Does jnius remain a declared dependency?

Long-term, I hope that we can make it optional.

In the short term, it feels too ingrained and is effectively required to do nearly anything. (At least this is how it's felt as I've worked to integrate this PR.)

So for this PR, I'd say let's try to aim for: "pt.init() not required, but jnius is"

cmacdonald
cmacdonald reviewed Jul 26, 2024
View reviewed changes
pyterrier/java.py Outdated Show resolved Hide resolved
seanmacavaney and others added 28 commits August 10, 2024 13:35
@seanmacavaney
move retrieve.py back to retriever.py
5e8f5b4
@seanmacavaney
Retrieve -> Retriever
12fef49
@seanmacavaney
Merge branch 'java' into java_terrier_retrieve
ae3d08f
@seanmacavaney
fix typo
8347a3b
@seanmacavaney
a bunch of BatchRetrieve -> Retriever (mostly in docs)
e6da26b
@seanmacavaney
merge error
bdcfa88
@seanmacavaney
Merge pull request #449 from terrier-org/java_terrier_retrieve
cb271f6 
Use pt.terrier.Retriever instead of pt.BatchRetrieve
@cmacdonald
Merge commit '4dd0752' into java_backport_453
972ce73
@cmacdonald
fix warning message to correctly split out pkg defn
bf785ee
@cmacdonald
upgrade for java branch
4be5ee8
@cmacdonald
make it easier to take env variables
87ccb05
@cmacdonald
use !r repr for strings
59e2adc
@seanmacavaney
Update push.yml
488bd03
@seanmacavaney
deprecated modifies the class so need stubs for deprecated transformers
8134536
@cmacdonald
use tiebreak results for RM3
4eb0799
@cmacdonald
reduce digits for term weights to avoid rounding errors on different …
d249116 
…platforms
@cmacdonald
wip - docvectors support in FeaturesRetrieve
608419a
@cmacdonald
improved test cases
f903c90
@cmacdonald
configurable DV matching implementation
b5b5b87
@cmacdonald
ensure 5.10 is there before tests will run
7c868e9
@seanmacavaney
Merge pull request #455 from terrier-org/dv
087c29d 
docvectors implementation for Feature retrieval
@seanmacavaney
Revert "Merge pull request #455 from terrier-org/dv"
bc6cb51 
This reverts commit 087c29d, reversing
changes made to 8134536.

We'll make this as a seprate PR to main later
@seanmacavaney
Merge pull request #454 from terrier-org/java_backport_453
1c46751 
Backport #453 to Java branch
@cmacdonald
flash before RM3
cad18c1
@seanmacavaney
mergeing rm3 tests back into the main rewrite test file
d726e4a
@seanmacavaney
in a short interim
57fe30d
@cmacdonald
add deprecation on (F)BR.from_dataset
8159417
@cmacdonald
Merge branch 'java' of github.com:terrier-org/pyterrier into java
81bc4d0
@cmacdonald cmacdonald merged commit 184d39b into master Aug 16, 2024
15 of 21 checks passed
@seanmacavaney seanmacavaney mentioned this pull request Aug 16, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacdonald cmacdonald cmacdonald left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanmacavaney @cmacdonald