Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify docstring for indexing with regards to metadata #394

Merged
merged 2 commits into from
Aug 30, 2023
Merged

clarify docstring for indexing with regards to metadata #394

merged 2 commits into from
Aug 30, 2023

Conversation

lukaszett
Copy link
Contributor

see #393

seanmacavaney
seanmacavaney approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@seanmacavaney seanmacavaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yeah, I agree that this behaviour be more clearly expressed.

I made a minor tweak (cropped -> truncated) to be slightly more precise.

@seanmacavaney seanmacavaney merged commit 6698e36 into terrier-org:master Aug 30, 2023
0 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmacavaney seanmacavaney seanmacavaney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukaszett @seanmacavaney